Add line breaks to precompiled schemas so that git can merge changes in the output#5
Open
Knagis wants to merge 1 commit intowebpack:mainfrom
Open
Add line breaks to precompiled schemas so that git can merge changes in the output#5Knagis wants to merge 1 commit intowebpack:mainfrom
Knagis wants to merge 1 commit intowebpack:mainfrom
Conversation
Author
|
@sokra could you please take a look at this? it should reduce how frequently PR rebases are needed in webpack. |
Member
|
For performance reasons this is a minimized file. Adding prettier would increase the file size a lot... |
Author
|
Tested (this time more likely accurately) - 5.69.0 version size increased from 218KB to 283KB |
Author
|
sadly With this it is possible to get nice "formatting" with just 6KB increase my intent was to avoid new dependencies for the package, so only terser and prettier are available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently the output is a single line which means at every single change in the WebpackOptions.check.js file is a conflict and needs manual rebase.
This PR applies
prettierto the minified output, resulting in still mangled code, but split in lines that git should be able to handle.