Improve performance of SqlParser::getNextPlaceholder() method#482
Improve performance of SqlParser::getNextPlaceholder() method#482
SqlParser::getNextPlaceholder() method#482Conversation
|
Any benchmarks? |
There was a problem hiding this comment.
Pull request overview
This PR optimizes PostgreSQL SQL parsing by speeding up how the next placeholder is found, specifically by making identifier skipping more efficient inside SqlParser::getNextPlaceholder().
Changes:
- Introduced a cached identifier character set (
IDENTIFIER_CHARS) for fast scanning. - Replaced the per-character
matchloop inskipIdentifier()with astrspn()-based implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
============================================
- Coverage 96.70% 96.68% -0.03%
+ Complexity 408 406 -2
============================================
Files 67 67
Lines 1214 1206 -8
============================================
- Hits 1174 1166 -8
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Related PR
AbstractSqlParserclass methods db#1159